Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare link system crypto #300

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Sep 27, 2024

It is best practice to link to the operating system's libcrypto so we get security updates from OS security updates.

This PR prepare the build and release scripts so that quicer can be built with three openssl variants.

  • openssl
  • openssl3
  • sys
    sys means link to the existing libcrypto of OS and the openssl version is decided by the version of libcrypto.

release pipelines are made for emqx build image only.

note: sys doesn't work with os : el9

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11068027067

Details

  • 0 of 15 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 86.427%

Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_nif.c 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_config.c 2 87.27%
Totals Coverage Status
Change from base Build 10956999496: -0.2%
Covered Lines: 3897
Relevant Lines: 4509

💛 - Coveralls

@qzhuyan qzhuyan merged commit 0a3107f into emqx:main Sep 27, 2024
44 checks passed
@qzhuyan qzhuyan deleted the dev/william/prepare-link-system-crypto branch September 27, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants